Skip to content

feat: remove mock seedless controller from performance tests #28713

Open
grvgoel81 wants to merge 17 commits intomainfrom
fix/perforamce-tests-remove-mock-api
Open

feat: remove mock seedless controller from performance tests #28713
grvgoel81 wants to merge 17 commits intomainfrom
fix/perforamce-tests-remove-mock-api

Conversation

@grvgoel81
Copy link
Copy Markdown
Contributor

@grvgoel81 grvgoel81 commented Apr 13, 2026

Description

This PR scopes Metro and OAuth mock behavior so onboarding performance tests can use the real seedless-onboarding controller

Jira: https://consensyssoftware.atlassian.net/browse/TO-677

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: Seedless performance and QA mock OAuth

  Scenario: Performance seedless onboarding completion
    Given SEEDLESS_ONBOARDING_ENABLED and performance onboarding env are configured for BrowserStack
    When the seedless Apple or Google performance onboarding test runs through onboarding success and Predict dismiss
    Then the test passes without waiting on wallet main screen and reported timers exclude post-wallet steps

Screenshots/Recordings

Before

After

Screen.Recording.2026-04-13.at.10.29.10.AM.mov
Screen.Recording.2026-04-13.at.10.27.03.AM.mov
Screen.Recording.2026-04-13.at.12.44.04.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Medium risk because it changes how E2E_MOCK_OAUTH routes through token exchange and seedless authentication and adjusts Metro module mocking behavior, which can affect CI/E2E flows and UAT OAuth config selection.

Overview
Onboarding performance runs now use the real seedless onboarding controller while still supporting a QA-mock OAuth token exchange path, so TOPRF auth can run against live nodes.

This adds OAUTH_BUILD_TYPE=main_uat to Bitrise BrowserStack builds and allows overriding OAuth config via process.env.OAUTH_BUILD_TYPE. The QA mock token exchange now generates a unique +e2e@web3auth.io email by default, uses real-ish OAuth client IDs in mocks, and always proceeds to seedless authenticate (removing the prior short-circuit), with updated tests and improved mock server logging/fallback behavior.

Reviewed by Cursor Bugbot for commit e6160df. Configure here.

@grvgoel81 grvgoel81 self-assigned this Apr 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-onboarding Onboarding team label Apr 13, 2026
@grvgoel81 grvgoel81 changed the title Fix/perforamce tests remove mock api fix: remove mock seedless controller from performance tests Apr 13, 2026
Comment thread app/core/OAuthService/QAMockOAuthService.ts Fixed
Comment thread app/core/OAuthService/QAMockOAuthService.ts Fixed
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e6160df. Configure here.

Comment thread app/core/OAuthService/OAuthService.test.ts
Comment thread app/core/OAuthService/OAuthLoginHandlers/constants.ts Outdated
Comment thread app/core/OAuthService/OAuthService.ts
@grvgoel81 grvgoel81 changed the title fix: remove mock seedless controller from performance tests feat: remove mock seedless controller from performance tests Apr 13, 2026
@github-actions github-actions Bot added size-L and removed size-M labels Apr 13, 2026
@grvgoel81 grvgoel81 marked this pull request as ready for review April 15, 2026 09:28
@grvgoel81 grvgoel81 requested review from a team as code owners April 15, 2026 09:28
@github-actions github-actions Bot added the risk-high Extensive testing required · High bug introduction risk label Apr 16, 2026
@grvgoel81 grvgoel81 marked this pull request as draft April 22, 2026 03:42
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
12 value mismatches detected (expected — fixture represents an existing user).
View details

@grvgoel81 grvgoel81 marked this pull request as ready for review April 29, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk-high Extensive testing required · High bug introduction risk size-L team-onboarding Onboarding team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants